Run http logs exporter only once and async #1323
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubno
requested changes
Oct 8, 2025
Bumped |
jakubno
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where updates of
mmdsChanare silenced forever as we start http logger exporter sync that forever blocks the loop. This was actually causing logger MMDs not to be updated after the sandbox resumed.Related to #1243, as this is the reason why older sandboxes started before the introduction of the hyperloop server are still sending logs to the old IP address after the sandbox was paused and resumed later.
Note
Start HTTP logs exporter asynchronously to prevent blocking MMDS updates and bump version to 0.3.5.
packages/envd/internal/logs/exporter/exporter.go: Runstart(ctx)in a goroutine on first MMDS update to avoid blocking the listener and allow ongoing MMDS updates.packages/envd/main.go: BumpVersionto0.3.5.Written by Cursor Bugbot for commit 8a9ac4b. This will update automatically on new commits. Configure here.