Skip to content

Conversation

chunkitmax
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 23, 2025

Deploying signatory with  Cloudflare Pages  Cloudflare Pages

Latest commit: d65702c
Status: ✅  Deploy successful!
Preview URL: https://bf62ade2.signatory.pages.dev
Branch Preview URL: https://req-op-kinds-check.signatory.pages.dev

View logs

Copy link
Contributor

@stephengaudet stephengaudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ecadlabs/signatory/blob/main/signatory.yaml

I think lines 66 through 80 in the example config file^ at the root of this project could be updated with this code change so that it continues to provide an accurate example

@stephengaudet
Copy link
Contributor

more important than the accuracy of the example config file, I think the implementation is not entirely correct.
this config file has "attestation_with_dal" as a child of "generic" when it should be a sibling to "generic", and so, Signatory should error on start with the following:
tezos: tz3MhmeqpudUqEX8PYTbNDF3CVcnnjNQoo8N: log_payloads: true allow: generic: - transaction - attestation_with_dal block: endorsement:

however, Signatory starts with the above config. notable, Signatory does error on start with the following:

tezos: tz3MhmeqpudUqEX8PYTbNDF3CVcnnjNQoo8N: log_payloads: true allow: generic: - transaction - completely_incorrect_config_entry block: endorsement:

So, we should be checking that the generic block has only the "kinds" that are valid. operations that are not kinds of generic should also cause error (like attestation_with_dal, attestation, preattestation, block..)

@jevonearth jevonearth removed the request for review from stephengaudet October 3, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants