-
Notifications
You must be signed in to change notification settings - Fork 21
add BLS proof of possession control #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying signatory with
|
| Latest commit: |
01c77ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://30fd3c65.signatory.pages.dev |
| Branch Preview URL: | https://665-bls-pop-control.signatory.pages.dev |
|
Proof that POP is working in the branch: set allow POP in the yaml, the check with cli listPublic Key Hash: tz4RA7FyhGmNm5brkKoDUP76gvcbH769gRud
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. i check that it is working by pulling the branch and running the code.
- rename config update function for integration tests - update Dockerfile to fix wrong version of base image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| protocol, err := integrationtest.GetCurrentProtocol() | ||
| assert.NoError(t, err) | ||
|
|
||
| if strings.Compare(protocol, "PtSeouL") >= 0 { // only test this for protocols >= PtSeouL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Protocol Version Comparison Fails
The protocol version comparison using strings.Compare() is unreliable. Tezos protocol hashes are base58-encoded identifiers whose lexicographical order doesn't reflect chronological version progression. Comparing a full hash against a partial string further compounds this, potentially causing tests to run or skip on incorrect protocol versions.
Note
Adds per-key BLS Proof of Possession gated by
allow_proof_of_possession, enforces it in POP endpoint, updates CLI listing, tests, and documentation.PublicKeyPolicy.AllowProofOfPossession; enforce inProvePossession(reject when disabled; improved errors).tz4keys; warn when set on non-BLS keys.TezosPolicywithyaml:"allow_proof_of_possession".listtemplate to displayAllow Proof of Possession.tz4key in integration configs.docs/proof_of_possession.mdand link fromREADMEandstart.md.Written by Cursor Bugbot for commit 51fcb2f. This will update automatically on new commits. Configure here.