ddspy: initial qos_provider support impl.
#301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of `QosProvider` class. Support for `qos_provider` functionality in python API + basic test implemntation.
dpotman
reviewed
Jul 21, 2025
cyclonedds/qos_provider.py
Outdated
| self._qos_provider, kind, bkey, ct.byref(cqos) | ||
| ) | ||
| if ret < 0: | ||
| raise DDSException(ret, f"Occured trying to get_topic_qos {repr(self)}") |
There was a problem hiding this comment.
get_topic_qos in the error message, but this is a generic function
cyclonedds/qos_provider.py
Outdated
| bpath, ct.byref(self._qos_provider), bscope | ||
| ) | ||
| if ret < 0 or not self._qos_provider: | ||
| raise DDSException(ret, f"Occured when initialize {repr(self)}") |
There was a problem hiding this comment.
Suggested change
| raise DDSException(ret, f"Occured when initialize {repr(self)}") | |
| raise DDSException(ret, f"Occured while initializing {repr(self)}") |
Fix exception messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
QosProviderclass.Support for
qos_providerfunctionality in python API + basic testimplementation.