Skip to content

Allow conversion from OffsetDateTime to java.sql.Timestamp #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow conversion from OffsetDateTime to java.sql.Timestamp #2294

wants to merge 1 commit into from

Conversation

TheChronicler
Copy link

No description provided.

rfelcman
rfelcman requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I'm not sure about this change. What about time zone part? It's removed during .toLocalDateTime(). Method convertObjectToTimestamp is about "Zoneless" date/time types.
I think, that solution in user code based on @Convert and @Converter is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rfelcman rfelcman rfelcman requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheChronicler @rfelcman