Skip to content

Memory leak in DescriptorQueryManager::cachedExpressionQueries when using HistoryPolicy #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.7
Choose a base branch
from
Open

Memory leak in DescriptorQueryManager::cachedExpressionQueries when using HistoryPolicy #861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...rsistence.core/src/org/eclipse/persistence/internal/queries/ExpressionQueryMechanism.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,7 +1774,8 @@ public void prepareUpdateObject() {
boolean useCache = (row == null || !(getQuery().shouldValidateUpdateCallCacheUse() && row.hasNullValueInFields()));

// PERF: Check the descriptor update SQL call cache for a matching update with the same fields.
Vector updateCalls = getDescriptor().getQueryManager().getCachedUpdateCalls(getModifyRow().getFields());
final Vector<DatabaseField> updateCallsKey = org.eclipse.persistence.internal.helper.NonSynchronizedVector.newInstance(getModifyRow().getFields());
Vector updateCalls = getDescriptor().getQueryManager().getCachedUpdateCalls(updateCallsKey);
// If the calls were cached then don't need to prepare.
if (updateCalls != null && useCache == true) {
int updateCallsSize = updateCalls.size();
Expand Down Expand Up @@ -1819,7 +1820,7 @@ public void prepareUpdateObject() {
updateCalls.add(getCall());
}
}
getDescriptor().getQueryManager().putCachedUpdateCalls(getModifyRow().getFields(), updateCalls);
getDescriptor().getQueryManager().putCachedUpdateCalls(updateCallsKey, updateCalls);
}
}

Expand Down