Extended checks for multiple assignments to the same feature #2057
+451
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #1412 and #1766 and improves and extends the checks of multiple assignments (in the grammar) to the same feature/property (in the AST):
?=,=and+=for the same feature: A warning (no error) is shown, if values are assigned with different operators to the same feature. This is prone to data loss, among others.=with+=.=(or?=):?=as assignment operator to the same feature.?=,=and+=, and 2nd for multiple assignments with?=or=) got an issue code, which is used in the 2nd case for a corresponding, new code action (for=only, see above) and which will be relevant for serializing ASTs back to text in the future.