Skip to content
This repository was archived by the owner on Aug 11, 2025. It is now read-only.

Conversation

Michael5601
Copy link
Contributor

This new folder structure mirrors the folder structure of eclipse-svg and will be used to save the SVGs for the modern eclipse icon pack.

empty .gitkeep files need to be added as git will ignore empty folders. As soon as one icon is introduced in the folder, the .gitkeep file can be deleted.

@Michael5601
Copy link
Contributor Author

@BeckerWdf as discussed this PR will create a new folder structure for the modern eclipse icon pack. I did not find a better solution than using .gitkeep files so that git will persist the structure.

I am open for better ideas.

@Michael5601 Michael5601 changed the title Create empty folder structure for Create empty folder structure for modern icon pack Mar 31, 2025
@laeubi
Copy link
Contributor

laeubi commented May 25, 2025

Why not create the structure once there is a real file? Also I'm a bit concerned about the name, what today is considered "modern" will tomorrow be "old" ... can we not came up with a little bit more descriptive name?

@Michael5601
Copy link
Contributor Author

Michael5601 commented May 25, 2025

Why not create the structure once there is a real file? Also I'm a bit concerned about the name, what today is considered "modern" will tomorrow be "old" ... can we not came up with a little bit more descriptive name?

The idea is to fill all folders bit by bit and to have an overview of still missing icons in the new style. I thought this would be the best way to provide this overview. I can also add the icons that I already created (about 50 icons mostly org.eclipde.debug.ui as prove of concept).

Regarding the name: I will rename the folder to eclipse-dual-tone-icon-pack.

This new folder structure will be used to save the SVGs for the dual-tone eclipse icon pack.

empty .gitkeep files need to be added as git will ignore empty folders. As soon as one icon is introduced in the folder, the .gitkeep file can be deleted.
@Michael5601 Michael5601 force-pushed the Eclipse-Modern-Icon-Pack branch from c983cdf to 0e70767 Compare May 25, 2025 12:12
@laeubi
Copy link
Contributor

laeubi commented May 25, 2025

I think a (check) list as an Github issue will serve the same purpose and not clutter the repository with .keep files (> 400!).

I also don't think that the structure in this repo should reflect any bundle names in another repository, instead we should really think about a semantic naming here (e.g. actions like refresh.svg, wizards and so on) and try to reduce the duplication/copy effort taken.

@Michael5601
Copy link
Contributor Author

I think a (check) list as an Github issue will serve the same purpose and not clutter the repository with .keep files (> 400!).

I also don't think that the structure in this repo should reflect any bundle names in another repository, instead we should really think about a semantic naming here (e.g. actions like refresh.svg, wizards and so on) and try to reduce the duplication/copy effort taken.

I think you are right that this PR is overkill for the icons that are created by now. I will push this project until all icons of org.eclipse.debug.ui are created for the dual-tone icon pack, which is sufficient for a prove of concept and screenshots of the new look in the Eclipse Debug View environment. Afterwards I plan to focus on different projects.

The icons and the style guide can then be used in the future if the Eclipse community is interested in creating a dual-tone icon pack.

I will close this PR and provide a folder for the icons that I already created where the style guide is proposed.

@Michael5601 Michael5601 deleted the Eclipse-Modern-Icon-Pack branch May 27, 2025 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants