Publisher remove extension #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amvanbaren
force-pushed
the
publisher-remove-extension
branch
2 times, most recently
from
ad9d120 to
6be48b3
Compare
Contributor
|
might also fix #58. |
Contributor
|
@chrisguindon @netomi FYI, here is the PR to allow a publisher to remove their own extensions. |
Contributor
|
@amvanbaren I'm good with this. @netomi @chrisguindon ? |
Contributor
|
I did test the PR locally, and I could successfully delete an extension. The extension / versions is / are deleted from the database instead of marking them as inactive. I wonder if we want to allow users to explicitly remove entries from the db as this would make tracing of potentially malicious extension very hard. Reviews for the deleted extensions are not touched, thus they still are marked as active in the database, though there is no corresponding extension anymore, violating referential integrity. Other than that, the PR looks good to me. |
amvanbaren
force-pushed
the
publisher-remove-extension
branch
from
6be48b3 to
3a6cc5e
Compare
amvanbaren
force-pushed
the
publisher-remove-extension
branch
from
3a6cc5e to
a84764e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EclipseFdn/open-vsx.org#5336
Fixes #58