[956] Refactor DataReaderBase normalization/denormalization #1008
+89
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor of
normalize_*
anddenormalize_*
methods (normalize_source_channels
,normalize_target_channels
,denormalize_source_channels
,denormalize_target_channels
) in data_reader_base.py to avoid code duplication.Introduced helper functions (
_normalize
and_denormalize
) that encapsulate the shared logic. Each method would then call the helper with the appropriate indices, mean, and standard deviation arrays.Replaced the
assert
statement with an "if + ValueError
"Issue Number
Closes #956
Checklist before asking for review
./scripts/actions.sh lint
./scripts/actions.sh unit-test
./scripts/actions.sh integration-test
launch-slurm.py --time 60