-
Notifications
You must be signed in to change notification settings - Fork 38
Ktezcan/dev/iss941 encode targets sepfstep #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kctezcan
wants to merge
25
commits into
ecmwf:develop
Choose a base branch
from
MeteoSwiss:ktezcan/dev/iss941_encode_targets_sepfstep
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ktezcan/dev/iss941 encode targets sepfstep #1019
kctezcan
wants to merge
25
commits into
ecmwf:develop
from
MeteoSwiss:ktezcan/dev/iss941_encode_targets_sepfstep
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an dditional PR over a previous PR: #961
The previous one introduces a new function to embed cells for the targets. This PR uses the existing
embed_cells()
function to embed the target tokens. The purpose is to reduce duplicated code and prevent potential "code rot" etc..I have tested both training and inference with this.
Issue Number
Ref #941
Refs #941
Closes #941
Closes #941
Checklist before asking for review
./scripts/actions.sh lint
./scripts/actions.sh unit-test
./scripts/actions.sh integration-test
launch-slurm.py --time 60