Skip to content

Conversation

enssow
Copy link
Contributor

@enssow enssow commented Oct 6, 2025

Description

Adds a check into actions.sh so developers can check that the pyproject toml files are consistent across subpacakges and main pacakge

CHanges:

  • added toml-check to actions.sh and corresponding check_tomls.py script
  • have disabled lint check for print for the script so the results can be read from the terminal
  • Open to suggestions on alternative ways to run the test e.g. in intergration or as a pytest, I chose to do it like this as it is less invasive and can be run by those specifically maintaining the package repos

Issue Number

Closes #883

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint have disabled lint check for print for the script so the results can be read from the terminal
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Synchronize configuration of the sub-packages
1 participant