[big merge][1300][model] Assemble diffusion model #1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented Identity class TODO: implement EMATeacher
The big question on the EMA teacher side to me is how to allow for a fleixble teacher and student architecture that can differ We updated some APIs of the abstract base class to allow the ema_model forward, subject to change given the loss calculator, which is imho the second big question mark
Easier to read and as batchsize gets more complicated in SSL this will be a useful abstraction
It runs so far. Next steps: - Route all the config options - Start writing the loss functions to understand the state requirements
…andom and healpix masking. Open issues with _coords_local, centroids and probably other things.
TODO: - Forecast still needs to be adapted - Some more cleanup of variable naming, return values etc
* Add to device to ModelBatch, etc & adapt model TODO adapt validate and inference TODO test forecasting and multiple stream because predict changed substantially * Rename view to sample and fix validate * Revert predict function and fix inference * Fix invalid access with mask * Linting * Fixed handling of target_idxs and other minor issues --------- Co-authored-by: sophiex <[email protected]> Co-authored-by: Christian Lessig <[email protected]>
… up fixes required to handle partially filler source/target streams (because source has no target values, eg).
…tion (#1397) * initial changes * more changes * removed extra print parameters statement * changed names for backward checkpoint loading * added encoder. to module names in sharding * adding encoder. to embed_engine * added back the conditions for param printong * lint * forecast config * switch back to MTM config * lint
…ough this. This commit also changes the number of forecast steps that are taken. The old loop was at least one step too far. Unclear why the problem occurred now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We assemble the different PRs of the latent diffusion forecast engine together to test their compatibility and perform first explorations.
Issue Number
Closes #1300
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60