Set default value for config file #694
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangguth89
suggested changes
Aug 8, 2025
| type=str, | ||
| help="Path to the configuration yaml file for plotting. e.g. config/plottig_config.yaml", | ||
| help="Path to the configuration yaml file for plotting. e.g. config/eval_config.yml", | ||
| default="config/eval_config.yml" |
There was a problem hiding this comment.
This is a hard-coded, relative paths, i.e. its validity depends on the directory from where run_evaluation.py is called.
Please make use of _REPO_ROOT from config.py here.
| { name = "torch", marker = "sys_platform == 'macosx'", specifier = "==2.6.0", index = "https://download.pytorch.org/whl/cpu" }, | ||
| { name = "tqdm" }, | ||
| { name = "weathergen-common", editable = "packages/common" }, | ||
| { name = "weathergen-evaluate", editable = "packages/evaluate" }, |
|
Has been implemented in #1028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a default value to the
run_evaluate.pyto delivereval_config.ymlif no--configargument is passed.Type of Change
Issue Number
resolves #693
Code Compatibility
Code Performance and Testing
uv run evaluateand it works$WEATHER_GENERATOR_PRIVATEdirectory