-
Notifications
You must be signed in to change notification settings - Fork 38
Jk/develop/gamma decay #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…evelop/fe_experiments
…evelop/fe_experiments
…evelop/fe_experiments
config/default_config.yml
Outdated
- "mse" | ||
- 1.0 | ||
|
||
timestep_weight: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this backwards compatible?
return (max_value - min_value) * np.cos(latitudes_radian) + min_value | ||
|
||
|
||
def gamma_decay(forecast_steps, gamma): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can put this in a util file?
Wiki page for loss weighting options: https://gitlab.jsc.fz-juelich.de/esde/WeatherGenerator-private/-/wikis/home/Model-and-training-configuration/Loss-weighting |
Description
This PR enables to provide a weighting function to distinctly weight forecast steps in the loss calculations.
The implemented function is a gamma function with a scale factor. The name of the weighting function and the scale factor are provided in the
default_config.yaml
.In principle other functions could be implemented within the same structure.
Issue Number
Closes #904
Checklist before asking for review
./scripts/actions.sh lint
./scripts/actions.sh unit-test
./scripts/actions.sh integration-test
launch-slurm.py --time 60