fix(metadata): Patching when receiving entry is not a dict #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
bug
HCookie
approved these changes
Oct 3, 2025
gmertes
pushed a commit
that referenced
this pull request
Oct 15, 2025
🤖 Automated Release PR This PR was created by `release-please` to prepare the next release. Once merged: 1. A new version tag will be created 2. A GitHub release will be published 3. The changelog will be updated Changes to be included in the next release: --- ## [0.8.0](0.7.3...0.8.0) (2025-10-15) ### Features * Add requirements subcommand ([#245](#245)) ([fd0877c](fd0877c)) * Better support for dynamic forcings and coupling in prepml ([#262](#262)) ([fd0877c](fd0877c)) * Lazy torch loading ([#277](#277)) ([fd0877c](fd0877c)) * Replace no grad with inference mode ([#331](#331)) ([4b7c495](4b7c495)) * Support empty input files ([#342](#342)) ([8078a89](8078a89)) ### Bug Fixes * Consolidate path behaviour on outputs ([#339](#339)) ([ba8faf1](ba8faf1)) * **metadata:** Patching when receiving entry is not a dict ([#338](#338)) ([ff222e2](ff222e2)) * Netcdf incorrect shape when using extract post-processors ([#346](#346)) ([95c23ae](95c23ae)), closes [#341](#341) * **parallel runner:** Support base class with main_argument decorator ([#333](#333)) ([7ec5cce](7ec5cce)) * Update cutout due to [#262](#262) ([#334](#334)) ([35c1cdb](35c1cdb)) ### Miscellaneous Chores * Bump 0.8.0 ([ec25c99](ec25c99)) --- > [!IMPORTANT] > Please do not change the PR title, manifest file, or any other automatically generated content in this PR unless you understand the implications. Changes here can break the release process. >⚠️ Merging this PR will: > - Create a new release > - Trigger deployment pipelines > - Update package versions **Before merging:** - Ensure all tests pass - Review the changelog carefully - Get required approvals [Release-please documentation](https://github.com/googleapis/release-please)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing an edge case in the
external_graphrunner when used with a LAM model. When using this runner with thegraph_datasetoption, it will patch thedataloader.datasetentry:anemoi-inference/src/anemoi/inference/runners/external_graph.py
Lines 189 to 199 in 196aa55
But if the existing
dataloader.datasetentry in the metadata happens to be a list of datasets, the patching crashes. When patching an existing entry, the patch function did not check if the receiving entry is also a dictionary. In the case of a list on the receiving side, it would try to index the list with the incoming dictionary keys. This PR fixes that.Also adds a test for this function.
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.