Skip to content

Conversation

tweska
Copy link
Member

@tweska tweska commented Sep 29, 2025

Required support for parsing vectors of subconfigurations (MUL-291).

πŸŒˆπŸŒ¦οΈπŸ“–πŸš§ Documentation πŸš§πŸ“–πŸŒ¦οΈπŸŒˆ
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-160

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.
βœ… Project coverage is 56.65%. Comparing base (2450a3a) to head (43fe507).

Files with missing lines Patch % Lines
src/multio/action/scale/Scale.h 44.44% 5 Missing ⚠️
src/multio/datamod/core/NestedRecord.h 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #160      +/-   ##
===========================================
+ Coverage    56.62%   56.65%   +0.02%     
===========================================
  Files          318      320       +2     
  Lines        20649    20674      +25     
  Branches      1570     1574       +4     
===========================================
+ Hits         11693    11713      +20     
- Misses        8956     8961       +5     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@pgeier pgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes are needed.

@tweska tweska force-pushed the feature/datamod-scale-action-conf branch from ec6603e to 44c33b4 Compare September 30, 2025 07:01
@tweska tweska force-pushed the feature/datamod-scale-action-conf branch from 0ec3b8b to 43fe507 Compare September 30, 2025 07:45
@tweska tweska requested a review from pgeier September 30, 2025 07:46
@MircoValentiniECMWF
Copy link
Collaborator

I recommend limiting datamod to the encoder for now. Until it is stable and merged into metkit, wider adoption will likely introduce breaking changes, requiring manual adaptation of all actions. I see this as very dangerous.

@tweska tweska marked this pull request as draft October 1, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants