Skip to content

Add support for field RVA #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: metadata-provider
Choose a base branch
from
Open

Add support for field RVA #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
454df95
field rva
fcurdi May 11, 2020
4485be4
whitespace
fcurdi May 11, 2020
389bb92
whitespace
fcurdi May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions MetadataProvider/AssemblyExtractor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,17 @@ private void ExtractField(SRM.FieldDefinitionHandle handle)
field.Visibility = GetVisibilityKind(fielddef.Attributes);
field.Value = ExtractFieldDefaultValue(fielddef);

field.SpecifiesRelativeVirtualAddress = fielddef.Attributes.HasFlag(SR.FieldAttributes.HasFieldRVA);
if (field.SpecifiesRelativeVirtualAddress)
{
var fieldDataReader = reader.GetSectionData(fielddef.GetRelativeVirtualAddress()).GetReader();
var fieldData = fieldDataReader.ReadBytes(fieldDataReader.Length);
field.Value = new Constant(fieldData)
{
Type = new ArrayType(PlatformTypes.Byte)
};
}

currentType.Fields.Add(field);
}

Expand Down
2 changes: 1 addition & 1 deletion Model/Types/TypeDefinitions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public class FieldDefinition : ITypeMemberDefinition, IFieldReference
public Constant Value { get; set; }

public bool IsStatic { get; set; }

public bool SpecifiesRelativeVirtualAddress { get; set; }
public FieldDefinition(string name, IType type)
{
this.Name = name;
Expand Down