Skip to content
This repository was archived by the owner on Sep 28, 2024. It is now read-only.

SmartListCell clears styleClass #1071

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SmartListCell clears styleClass #1071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa99f13
SmartListCell clears styleClass
Sep 8, 2019
f91f46a
Extracted clean up operations to method
Sep 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/main/java/tornadofx/ListView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,7 @@ open class SmartListCell<T>(val scope: Scope = FX.defaultScope, listView: ListVi
super.updateItem(item, empty)

if (item == null || empty) {
textProperty().unbind()
graphicProperty().unbind()
text = null
graphic = null
style = null
cleanUp()
clearCellFragment()
} else {
FX.ignoreParentBuilder = Once
Expand All @@ -170,6 +166,15 @@ open class SmartListCell<T>(val scope: Scope = FX.defaultScope, listView: ListVi
}
}

private fun cleanUp() {
textProperty().unbind()
graphicProperty().unbind()
text = null
graphic = null
style = null
styleClass.clear()
}

private fun clearCellFragment() {
cellFragment?.apply {
cellProperty.value = null
Expand Down