Digitization algorithm that reproduces the HGCROC measurement #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhkim-anl
changed the title
veprbl
reviewed
Nov 4, 2025
|
|
||
| #include <algorithms/algorithm.h> | ||
| #include <edm4eic/SimPulseCollection.h> | ||
| #include <edm4eic/RawHGCROCHitCollection.h> |
Member
There was a problem hiding this comment.
You will need to require EDM4eic 8.3.0 to use your code. Basically, see some of older changes removed in https://github.com/eic/EICrecon/pull/2121/files for inspiration.
|
|
||
| namespace eicrecon { | ||
|
|
||
| class PulseDigi_factory : public JOmniFactory<PulseDigi_factory, PulseDigiConfig> { |
Member
There was a problem hiding this comment.
Please come up with a more descriptive name than PulseDigi.
Member
There was a problem hiding this comment.
This algorithm needs a use somewhere. We don't add dead code. Either make a unit test or include this in the analysis chain.
Comment on lines
+23
to
+32
| ParameterRef<double> m_time_window{this, "time_window", config().time_window}; | ||
| ParameterRef<double> m_adc_phase{this, "adc_phase", config().adc_phase}; | ||
| ParameterRef<double> m_toa_thres{this, "toa_thres", config().toa_thres}; | ||
| ParameterRef<double> m_tot_thres{this, "tot_thres", config().tot_thres}; | ||
| ParameterRef<unsigned int> m_capADC{this, "capADC", config().capADC}; | ||
| ParameterRef<double> m_dyRangeADC{this, "dyRangeADC", config().dyRangeADC}; | ||
| ParameterRef<unsigned int> m_capTOA{this, "capTOA", config().capTOA}; | ||
| ParameterRef<double> m_dyRangeTOA{this, "dyRangeTOA", config().dyRangeTOA}; | ||
| ParameterRef<unsigned int> m_capTOT{this, "capTOT", config().capTOT}; | ||
| ParameterRef<double> m_dyRangeTOT{this, "dyRangeTOT", config().dyRangeTOT}; |
Member
There was a problem hiding this comment.
Suggested change
| ParameterRef<double> m_time_window{this, "time_window", config().time_window}; | |
| ParameterRef<double> m_adc_phase{this, "adc_phase", config().adc_phase}; | |
| ParameterRef<double> m_toa_thres{this, "toa_thres", config().toa_thres}; | |
| ParameterRef<double> m_tot_thres{this, "tot_thres", config().tot_thres}; | |
| ParameterRef<unsigned int> m_capADC{this, "capADC", config().capADC}; | |
| ParameterRef<double> m_dyRangeADC{this, "dyRangeADC", config().dyRangeADC}; | |
| ParameterRef<unsigned int> m_capTOA{this, "capTOA", config().capTOA}; | |
| ParameterRef<double> m_dyRangeTOA{this, "dyRangeTOA", config().dyRangeTOA}; | |
| ParameterRef<unsigned int> m_capTOT{this, "capTOT", config().capTOT}; | |
| ParameterRef<double> m_dyRangeTOT{this, "dyRangeTOT", config().dyRangeTOT}; | |
| ParameterRef<double> m_time_window{this, "timeWindow", config().time_window}; | |
| ParameterRef<double> m_adc_phase{this, "adcPhase", config().adc_phase}; | |
| ParameterRef<double> m_toa_thres{this, "toaThres", config().toa_thres}; | |
| ParameterRef<double> m_tot_thres{this, "totThres", config().tot_thres}; | |
| ParameterRef<unsigned int> m_capADC{this, "capADC", config().capADC}; | |
| ParameterRef<double> m_dyRangeADC{this, "dyRangeADC", config().dyRangeADC}; | |
| ParameterRef<unsigned int> m_capTOA{this, "capTOA", config().capTOA}; | |
| ParameterRef<double> m_dyRangeTOA{this, "dyRangeTOA", config().dyRangeTOA}; | |
| ParameterRef<unsigned int> m_capTOT{this, "capTOT", config().capTOT}; | |
| ParameterRef<double> m_dyRangeTOT{this, "dyRangeTOT", config().dyRangeTOT}; |
camelCase for JANA2 parameter names, and underscores for config names. Bonus points for making variable names consistent with what is used elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR is to reproduce the HGCROC measurement and store the corresponding data types,
RawHGCROCHitandHGCROCSample, from pulse. When HGCROC measures the TOT, it is stored in the same sample where the TOA is measured even though it is measured during a sample that is different from the TOA one. This means we should not finalize/output the sample immediately after scanning a time window in the code. Rather, we need to temporarily store the samples somewhere (like a buffer) until the TOT is measured or all the amplitudes are scanned. For this purpose, a class,HGCROCRawSamplewas used in this algorithm.More details will be presented at the next BIC simulation meeting.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No