-
Notifications
You must be signed in to change notification settings - Fork 30
feat(gui): Restore by seed with height #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(gui): Restore by seed with height #684
Conversation
src-gui/src/renderer/components/modal/seed-selection/SeedSelectionDialog.tsx
Outdated
Show resolved
Hide resolved
binarybaron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick
Einliterflasche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One suggestion regarding the input field.
We also should provide a blockheight by date field and a warning that not putting a height will cause a full scan.
src-gui/src/renderer/components/modal/seed-selection/SeedSelectionDialog.tsx
Show resolved
Hide resolved
|
Turns out using |
src-gui/src/renderer/components/modal/seed-selection/SeedSelectionDialog.tsx
Show resolved
Hide resolved
src-gui/src/renderer/components/modal/seed-selection/SeedSelectionDialog.tsx
Outdated
Show resolved
Hide resolved
src-gui/src/renderer/components/modal/seed-selection/SeedSelectionDialog.tsx
Outdated
Show resolved
Hide resolved
src-gui/src/renderer/components/modal/seed-selection/SeedSelectionDialog.tsx
Outdated
Show resolved
Hide resolved
src-gui/src/renderer/components/modal/seed-selection/SeedSelectionDialog.tsx
Outdated
Show resolved
Hide resolved
binarybaron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments regarding isolation of the block height parsing logic
|
Needs to be rebased due to #711. |
No description provided.