Skip to content

Conversation

@rafael-xmr
Copy link

No description provided.

Copy link

@binarybaron binarybaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

Copy link

@Einliterflasche Einliterflasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One suggestion regarding the input field.

We also should provide a blockheight by date field and a warning that not putting a height will cause a full scan.

@Einliterflasche
Copy link

Turns out using <TextField type="number" /> is not recommended (source). See if what the uk gov does is possible. That way users can't enter invalid characters (-, +, e, .) in the first place.

Copy link

@binarybaron binarybaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments regarding isolation of the block height parsing logic

@binarybaron binarybaron changed the title feat: restore by seed with height feat(gui): Restore by seed with height Nov 12, 2025
@binarybaron binarybaron added GUI Related to the Tauri GUI monero wallet labels Nov 12, 2025
@binarybaron
Copy link

Needs to be rebased due to #711.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI Related to the Tauri GUI monero wallet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants