Improved the img and headings tags #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

edisleka wants to merge 1 commit into elad2412:main from edisleka:main

edisleka commented Jan 7, 2024

When the image doesn't load the alt text comes in as italic, as advantage we're setting it apart from the rest of content
text-wrap: balance; on headings H1 to H6 -> Balance out the text that is used for headlines on two lines or more


          Improved the img and headings tags styles

c12624c

UniquePixels commented Jan 7, 2024

A couple of things:

When contributing to a project, you need to turn off any auto-formatters or configure them to the style of the project. Finding your changes in this PR is very difficult because so much of the existing code has been reformatted, creating multiple diffs.
As to these specific changes. They are pretty opinionated to me. Do these really go in a reset, which is about creating a blank canvas so that developers can do things as they like?

QINGCHARLES commented Sep 1, 2024

This is a bad PR. These are totally opinionated. The formatting issue is horrible.

This should just be a note in the README that alt text might blend into body copy if you don't style it.
I love "balance" for myself, but might not be what everyone was expecting. Let them set it if they want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet