Skip to content

feat: bump go to 1.25.1 #18121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 12, 2025
Merged

feat: bump go to 1.25.1 #18121

merged 13 commits into from
Sep 12, 2025

Conversation

kruskall
Copy link
Member

Motivation/summary

bump to latest stable version

go 1.25 adds native auto maxprocs so we don't need the automaxprocs lib
anymore.

remove dependency and related tests

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Blocked until wolfi go 1.25.0 image is published

@kruskall
feat: bump go to 1.25.0
688b995 
bump to latest stable version
@kruskall
feat: remove unused automaxprocs dependency and related tests
2cb30d3 
go 1.25 adds native auto maxprocs so we don't need the automaxprocs lib
anymore.

remove dependency and related tests
@kruskall kruskall requested a review from a team as a code owner August 13, 2025 06:17
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 13, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 8, 2025

This pull request is now in conflicts. Could you fix it @kruskall? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/go-1.25 upstream/feat/go-1.25
git merge upstream/main
git push upstream feat/go-1.25

@kruskall kruskall changed the title feat: bump go to 1.25.0 feat: bump go to 1.25.1 Sep 8, 2025
@kruskall kruskall mentioned this pull request Sep 9, 2025
Closed
@kruskall
test: remove subjectkeyid fips workaround
44f89d7 
go 1.25 switched to SHA-256 to fill in missing SubjectKeyId
in crypto/x509.CreateCertificate.

Remove the manual key generation to avoid sha1
@kruskall
ci: disable X25519MLKEM768 in fips tests
3af7347 
pass GODEBUG=tlsmlkem=0 to remove X25519MLKEM768 from enabled
by default curve list.

Go 1.25 allowed X25519MLKEM768 in fips mode but this might fail
if X25519 is used in fipsonly mode because X25519 is not allowed.

remove the curve from the default list until this is fixed upstream
@kruskall kruskall requested a review from a team as a code owner September 9, 2025 14:59
@kruskall
Copy link
Member Author

kruskall commented Sep 9, 2025

manually verified that the chainguard 1.25.1 docker image is available

v1v
v1v previously approved these changes Sep 9, 2025
View reviewed changes
simitt
simitt reviewed Sep 10, 2025
View reviewed changes
@kruskall kruskall requested a review from simitt September 10, 2025 11:44
@kruskall kruskall mentioned this pull request Sep 11, 2025
Closed
@kruskall kruskall requested a review from a team September 11, 2025 15:55
@kruskall kruskall enabled auto-merge September 12, 2025 13:20
@kruskall kruskall added this pull request to the merge queue Sep 12, 2025
Merged via the queue into elastic:main with commit 632899a Sep 12, 2025
18 of 19 checks passed
@kruskall kruskall deleted the feat/go-1.25 branch September 12, 2025 13:46
@kruskall
Copy link
Member Author

@Mergifyio backport 9.1 8.19

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 24, 2025 •
edited
Loading

backport 9.1 8.19

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 24, 2025
@kruskall @mergify
feat: bump go to 1.25.1 (#18121)
0473cbc 
* feat: bump go to 1.25.0

bump to latest stable version

* feat: remove unused automaxprocs dependency and related tests

go 1.25 adds native auto maxprocs so we don't need the automaxprocs lib
anymore.

remove dependency and related tests

* Update .go-version

* Update go.mod

* Update go.mod

* Update go.mod

* Update go.mod

* lint: regenerate notice files

* test: remove subjectkeyid fips workaround

go 1.25 switched to SHA-256 to fill in missing SubjectKeyId
in crypto/x509.CreateCertificate.

Remove the manual key generation to avoid sha1

* ci: disable X25519MLKEM768 in fips tests

pass GODEBUG=tlsmlkem=0 to remove X25519MLKEM768 from enabled
by default curve list.

Go 1.25 allowed X25519MLKEM768 in fips mode but this might fail
if X25519 is used in fipsonly mode because X25519 is not allowed.

remove the curve from the default list until this is fixed upstream

* Update ci.yml

(cherry picked from commit 632899a)

# Conflicts:
#	go.mod
#	go.sum
mergify bot pushed a commit that referenced this pull request Sep 24, 2025
@kruskall @mergify
feat: bump go to 1.25.1 (#18121)
7ca8e69 
* feat: bump go to 1.25.0

bump to latest stable version

* feat: remove unused automaxprocs dependency and related tests

go 1.25 adds native auto maxprocs so we don't need the automaxprocs lib
anymore.

remove dependency and related tests

* Update .go-version

* Update go.mod

* Update go.mod

* Update go.mod

* Update go.mod

* lint: regenerate notice files

* test: remove subjectkeyid fips workaround

go 1.25 switched to SHA-256 to fill in missing SubjectKeyId
in crypto/x509.CreateCertificate.

Remove the manual key generation to avoid sha1

* ci: disable X25519MLKEM768 in fips tests

pass GODEBUG=tlsmlkem=0 to remove X25519MLKEM768 from enabled
by default curve list.

Go 1.25 allowed X25519MLKEM768 in fips mode but this might fail
if X25519 is used in fipsonly mode because X25519 is not allowed.

remove the curve from the default list until this is fixed upstream

* Update ci.yml

(cherry picked from commit 632899a)

# Conflicts:
#	.github/workflows/ci.yml
#	go.mod
#	integrationservertest/go.mod
This was referenced Sep 24, 2025
Merged
Merged
kruskall added a commit that referenced this pull request Sep 24, 2025
@mergify @kruskall
[9.1] (backport #18121) feat: bump go to 1.25.1 (#18734)
2ca47dd 
* feat: bump go to 1.25.1 (#18121)

* feat: bump go to 1.25.0

bump to latest stable version

* feat: remove unused automaxprocs dependency and related tests

go 1.25 adds native auto maxprocs so we don't need the automaxprocs lib
anymore.

remove dependency and related tests

* Update .go-version

* Update go.mod

* Update go.mod

* Update go.mod

* Update go.mod

* lint: regenerate notice files

* test: remove subjectkeyid fips workaround

go 1.25 switched to SHA-256 to fill in missing SubjectKeyId
in crypto/x509.CreateCertificate.

Remove the manual key generation to avoid sha1

* ci: disable X25519MLKEM768 in fips tests

pass GODEBUG=tlsmlkem=0 to remove X25519MLKEM768 from enabled
by default curve list.

Go 1.25 allowed X25519MLKEM768 in fips mode but this might fail
if X25519 is used in fipsonly mode because X25519 is not allowed.

remove the curve from the default list until this is fixed upstream

* Update ci.yml

(cherry picked from commit 632899a)

# Conflicts:
#	go.mod
#	go.sum

* Update go.mod

* Update go.sum

* lint: fix linter issues

* lint: fix linter issues

---------

Co-authored-by: kruskall <[email protected]>
mergify bot added a commit that referenced this pull request Sep 24, 2025
@mergify @kruskall
[8.19] (backport #18121) feat: bump go to 1.25.1 (#18735)
e90e75b 
* feat: bump go to 1.25.1 (#18121)

* feat: bump go to 1.25.0

bump to latest stable version

* feat: remove unused automaxprocs dependency and related tests

go 1.25 adds native auto maxprocs so we don't need the automaxprocs lib
anymore.

remove dependency and related tests

* Update .go-version

* Update go.mod

* Update go.mod

* Update go.mod

* Update go.mod

* lint: regenerate notice files

* test: remove subjectkeyid fips workaround

go 1.25 switched to SHA-256 to fill in missing SubjectKeyId
in crypto/x509.CreateCertificate.

Remove the manual key generation to avoid sha1

* ci: disable X25519MLKEM768 in fips tests

pass GODEBUG=tlsmlkem=0 to remove X25519MLKEM768 from enabled
by default curve list.

Go 1.25 allowed X25519MLKEM768 in fips mode but this might fail
if X25519 is used in fipsonly mode because X25519 is not allowed.

remove the curve from the default list until this is fixed upstream

* Update ci.yml

(cherry picked from commit 632899a)

# Conflicts:
#	.github/workflows/ci.yml
#	go.mod
#	integrationservertest/go.mod

* Update ci.yml

* Delete integrationservertest/go.mod

* Update go.mod

* Update ci.yml

---------

Co-authored-by: kruskall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inge4pres inge4pres inge4pres approved these changes

@v1v v1v v1v left review comments

@simitt simitt Awaiting requested review from simitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kruskall @v1v @inge4pres @simitt