feat: return an error if tbs config fails #18379
Merged
+8
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
failure to process the tbs config will log a message and silently fallback to the default config with tbs disabled.
This is not ideal and doesn't match the behaviour of other configs which return an error to the caller.
Update the tbs config logic to return an error if processing fails
Update test to assert error on malformed configs
We might need to be careful with backporting (maybe only 9.x ?)
Checklist
For functional changes, consider:
How to test these changes
Related issues