Skip to content

Conversation

kruskall
Copy link
Member

Motivation/summary

failure to process the tbs config will log a message and silently fallback to the default config with tbs disabled.
This is not ideal and doesn't match the behaviour of other configs which return an error to the caller.

Update the tbs config logic to return an error if processing fails

Update test to assert error on malformed configs

We might need to be careful with backporting (maybe only 9.x ?)

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  • start apm-server with malformed tbs config
  • observe a failure

Related issues

failure to process the tbs config will log a message and silently
fallback to the default config with tbs disabled.
This is not ideal and doesn't match the behaviour of other configs
which return an error to the caller.

Update the tbs config logic to return an error if processing fails

Update test to assert error on malformed configs
@kruskall kruskall requested a review from a team as a code owner August 28, 2025 14:16
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Aug 28, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

1pkg
1pkg previously approved these changes Aug 28, 2025
make sure the error in tbs config tests is expected
@kruskall kruskall enabled auto-merge September 11, 2025 18:21
@kruskall kruskall added this pull request to the merge queue Sep 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2025
@kruskall kruskall added this pull request to the merge queue Sep 11, 2025
Merged via the queue into elastic:main with commit e21fce4 Sep 11, 2025
19 checks passed
@kruskall kruskall deleted the feat/tbs-config-error branch September 11, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants