merge queue: embarking 8.19 (5c36d44) and #18735 together #18736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* feat: bump go to 1.25.0 bump to latest stable version * feat: remove unused automaxprocs dependency and related tests go 1.25 adds native auto maxprocs so we don't need the automaxprocs lib anymore. remove dependency and related tests * Update .go-version * Update go.mod * Update go.mod * Update go.mod * Update go.mod * lint: regenerate notice files * test: remove subjectkeyid fips workaround go 1.25 switched to SHA-256 to fill in missing SubjectKeyId in crypto/x509.CreateCertificate. Remove the manual key generation to avoid sha1 * ci: disable X25519MLKEM768 in fips tests pass GODEBUG=tlsmlkem=0 to remove X25519MLKEM768 from enabled by default curve list. Go 1.25 allowed X25519MLKEM768 in fips mode but this might fail if X25519 is used in fipsonly mode because X25519 is not allowed. remove the curve from the default list until this is fixed upstream * Update ci.yml (cherry picked from commit 632899a) # Conflicts: # .github/workflows/ci.yml # go.mod # integrationservertest/go.mod
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch 8.19 (5c36d44) and #18735 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #18735.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by >= 1[🛡 GitHub branch protection]#approved-reviews-by >= 1[🛡 GitHub repository ruleset rule]#approved-reviews-by >= 1[🛡 GitHub repository ruleset rule]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset rule]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset rule]check-success=CLAcheck-success=lintcheck-success=system-testcheck-success=test (macos-latest)check-success=test (windows-2025)check-success = CLAcheck-neutral = CLAcheck-skipped = CLAcheck-success = lintcheck-neutral = lintcheck-skipped = lintcheck-success = buildkite/docs-build-prcheck-neutral = buildkite/docs-build-prcheck-skipped = buildkite/docs-build-prRequired conditions to stay in the queue:
#approved-reviews-by >= 1[🛡 GitHub branch protection]#approved-reviews-by >= 1[🛡 GitHub repository ruleset rule]#approved-reviews-by >= 1[🛡 GitHub repository ruleset rule]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset rule]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset rule]check-success = CLAcheck-neutral = CLAcheck-skipped = CLAcheck-success = lintcheck-neutral = lintcheck-skipped = lintcheck-success = buildkite/docs-build-prcheck-neutral = buildkite/docs-build-prcheck-skipped = buildkite/docs-build-pr