Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 20, 2025

Motivation/summary

Improve:

  • No more ad hoc post-checkout after using the BK PR Bot
  • No need to run the pre-command hook when running the upload step.

Fixes issues after using the BK PR Bot:

image

Otherwise it only supports main, release branches and feature branches, but no forked PRs

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues


This is an automatic backport of pull request #19188 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Oct 20, 2025
@mergify mergify bot requested a review from a team as a code owner October 20, 2025 08:52
@mergify mergify bot assigned v1v Oct 20, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify mergify bot added the queued label Oct 20, 2025
mergify bot added a commit that referenced this pull request Oct 20, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Oct 20, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #19220.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added dequeued and removed queued labels Oct 20, 2025
@kruskall
Copy link
Member

@v1v I think you need to sign the commits since it was changed iiuc

@v1v
Copy link
Member

v1v commented Oct 21, 2025

@v1v I think you need to sign the commits since it was changed iiuc

We solved the issue of unsigned commits with mergify, therefore mergify should fix this, but the merge-queue is failing in the CI

@v1v v1v enabled auto-merge (squash) October 21, 2025 16:34
@mergify
Copy link
Contributor Author

mergify bot commented Oct 21, 2025

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

* ci(packaging): support for PRs too

* avoid spamming

* run faster and remove unrequired post-checkout when using the BK PR Bot

(cherry picked from commit ab65423)
@v1v v1v force-pushed the mergify/bp/9.0/pr-19188 branch from d7a9a76 to e2f8ae3 Compare October 21, 2025 19:45
@v1v v1v merged commit 1ffd9f4 into 9.0 Oct 21, 2025
13 of 14 checks passed
@v1v v1v deleted the mergify/bp/9.0/pr-19188 branch October 21, 2025 19:49
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

cc @v1v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants