Skip to content

Conversation

@margaretjgu
Copy link
Member

@margaretjgu margaretjgu commented Oct 30, 2025

Closes #1096

@margaretjgu margaretjgu marked this pull request as draft October 30, 2025 19:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@margaretjgu margaretjgu changed the title enforce concrete numeric types Enforce concrete numeric types Oct 31, 2025
@margaretjgu margaretjgu marked this pull request as ready for review October 31, 2025 14:40
@margaretjgu margaretjgu force-pushed the concrete_numberic_types branch from ded4d8b to 873a655 Compare October 31, 2025 14:46
@margaretjgu margaretjgu requested a review from a team as a code owner October 31, 2025 14:46
@margaretjgu margaretjgu force-pushed the concrete_numberic_types branch from 873a655 to b37f14e Compare October 31, 2025 14:47
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@margaretjgu margaretjgu merged commit b2d5fcd into main Nov 5, 2025
8 checks passed
@margaretjgu margaretjgu deleted the concrete_numberic_types branch November 5, 2025 14:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5584-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2d5fcd056370329d48cc0285d46b26d038563f0
# Push it to GitHub
git push --set-upstream origin backport-5584-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-5584-to-9.1.

github-actions bot pushed a commit that referenced this pull request Nov 5, 2025
* draft rule

* tests, run lint

* prettier

(cherry picked from commit b2d5fcd)
margaretjgu added a commit that referenced this pull request Nov 5, 2025
* draft rule

* tests, run lint

* prettier

(cherry picked from commit b2d5fcd)

Co-authored-by: margaretjgu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Force usage of concrete numeric types instead of number

6 participants