-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Fix msearch rest-api-spec #130627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix msearch rest-api-spec #130627
Conversation
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, how did this come up?
In general, when I see this type of changes, my first reaction is "oh, does this really work?". I think adding a small yaml test for each of the new parameters would help increase that confidence.
I'm working on fixing the inconsistencies between https://github.com/elastic/elasticsearch-specification and rest-api-spec (as tracked in elastic/elasticsearch-specification#4796) in order to ultimately generate the rest-api-spec from the Elasticsearch specification. The broader context is that we're working towards moving the Elasticsearch specification to Elasticsearch itself. I understand why you would want a small YAML test, but it's not easy for me to do, especially as I'm currently dealing with 40 similar errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the tests
* Fix msearch rest-api-spec * Add YAML tests for added parameters
* Fix msearch rest-api-spec * Add YAML tests for added parameters
* Fix msearch rest-api-spec * Add YAML tests for added parameters
* Fix msearch rest-api-spec * Add YAML tests for added parameters
The code that reads these parameters is a bit scattered:
I've tested that all those parameters are accepted.