Run GeoIp YAML tests in multi-project cluster #131521
Open
+238
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samxbr
added
>non-issue
:Data Management/Ingest Node
samxbr
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR enables GeoIP YAML REST tests to run in multi-project clusters and fixes a bug in the DatabaseNodeService class. The changes include refactoring the database checking logic to support multi-project environments and adding new test infrastructure.
- Refactored
DatabaseNodeService.checkDatabases()to extract project-specific logic into a separate method - Added new YAML test suite for multi-project GeoIP functionality
- Fixed package declaration in existing Java test class
- Updated build configuration to support YAML REST tests
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| DatabaseNodeService.java | Refactored database checking logic to support multi-project clusters by extracting project-specific logic |
| IngestGeoIpClientMultiProjectYamlTestSuiteIT.java | Added new YAML test suite for multi-project GeoIP functionality |
| GeoIpMultiProjectIT.java | Fixed package declaration and removed redundant imports |
| build.gradle | Added YAML REST test plugin configuration and dependencies |
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change runs the GeoIP YAML REST tests in multi-project cluster, it also fixes a bug in
DatabaseNodeService.Sample test run