Skip to content

Conversation

ChrisHegarty
Copy link
Contributor

@ChrisHegarty ChrisHegarty commented Jul 22, 2025

This commit increases the delta in ESVectorUtilTests.testSoarDistance, similar to what we do in other tests.

closes #131652

This commit increases the delta in ESVectorUtilTests, similar to what we do in other tests.
@ChrisHegarty ChrisHegarty requested a review from iverase July 22, 2025 13:40
@ChrisHegarty ChrisHegarty added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.0 labels Jul 22, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@ChrisHegarty
Copy link
Contributor Author

ChrisHegarty commented Jul 22, 2025

Prior to this change, the following command fails very regularly. However, with this change the test appears stable.
./gradlew ":libs:simdvec:test" --rerun --tests "org.elasticsearch.simdvec.ESVectorUtilTests" -Dtests.iters=10000

@ChrisHegarty ChrisHegarty changed the title Increase delta in ESVectorUtilTests Increase delta in ESVectorUtilTests.testSoarDistance Jul 22, 2025
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty added the auto-backport Automatically create backport pull requests when merged label Jul 22, 2025
@ChrisHegarty ChrisHegarty merged commit 446942f into main Jul 22, 2025
33 of 34 checks passed
@ChrisHegarty ChrisHegarty deleted the ChrisHegarty-patch-2 branch July 22, 2025 15:02
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1

ChrisHegarty added a commit to ChrisHegarty/elasticsearch that referenced this pull request Jul 22, 2025
This commit increases the delta in ESVectorUtilTests.testSoarDistance, similar to what we do in other tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.1.1 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ESVectorUtilTests testSoarDistance failing
3 participants