Clean up awaitClusterState overloads
#132529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `logger` parameter is unused, it doesn't throw any checked exceptions, and there's no need for `protected` instance methods when they're also available as `public static`.
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
…EST_TIMEOUT is for
nielsbauman
approved these changes
Aug 7, 2025
DaveCTurner
added
auto-merge-without-approval
|
@DaveCTurner any chance you have time to open a Serverless PR as well to fix compilation and get this PR through? |
elasticsearchmachine
added
the
serverless-linked
|
Ah thanks Niels this one slipped off my radar. I opened the corresponding PR |
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 26, 2025
The `logger` parameter is unused, it doesn't throw any checked exceptions, and there's no need for `protected` instance methods when they're also available as `public static`. Backport of elastic#132529 to 9.1
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 26, 2025
The `logger` parameter is unused, it doesn't throw any checked exceptions, and there's no need for `protected` instance methods when they're also available as `public static`. Backport of elastic#132529 to 8.19
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2025
The `logger` parameter is unused, it doesn't throw any checked exceptions, and there's no need for `protected` instance methods when they're also available as `public static`. Backport of #132529 to 9.1
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2025
The `logger` parameter is unused, it doesn't throw any checked exceptions, and there's no need for `protected` instance methods when they're also available as `public static`. Backport of #132529 to 8.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
loggerparameter is unused, it doesn't throw any checkedexceptions, and there's no need for
protectedinstance methods whenthey're also available as
public static.