Wait for snapshot finalization in testSnapshotAPMMetrics()
#132767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an assertBusy() to testSnapshotAPMMetrics() to ensure the snapshot finalization code has had a chance to run and update the snapshot completed metrics. The awaitNumberOfSnapshotsInProgress(0) call returns after it observes the expected SnapshotsInProgress cluster state update, but the snapshot finalization code may not have been executed yet. Resolves: elastic#132731
JeremyDahlgren
added
>test
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Per discussions with Nick and Josh I'm closing this in favor of Nick's PR #132780 that does further refactoring, splitting the throttling testing into a separate test method. |
auto-merge was automatically disabled
August 14, 2025 14:27
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
assertBusy()totestSnapshotAPMMetrics()to ensure the snapshot finalization code has had a chance to run and update the snapshot completed metrics.The
awaitNumberOfSnapshotsInProgress(0)call returns after it observes the expectedSnapshotsInProgresscluster state update, but the snapshot finalization code may not have been executed yet.The change in #132686 only reduced the race condition window.
Resolves: #132731