ES|QL: refactor query generator and move it to testFixtures #134696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>test
elasticsearchmachine
added
v9.2.0
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ivancea
approved these changes
Sep 15, 2025
| package org.elasticsearch.xpack.esql.generator; | ||
|
|
||
| public interface QueryExecutor { | ||
| QueryExecuted execute(String command, int depth); |
There was a problem hiding this comment.
Some javadoc here could be nice. At least for that "depth", which I'm not sure what it is (From looking at this interface alone)
|
Waiting for #133804 to be merged first, to avoid conflicts. |
|
@luigidellaquila I've merged in #133804, thank you for waiting! |
…res' into esql/generator_to_fixtures
|
Thanks for letting me know @limotova! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the ES|QL query generator (decoupling it from
GenerativeRestTest) and moving it to textFixtures submodule, so that we can reuse it in other contexts