Simplify computation of resets in rate aggregation #134700
Merged
+312
−428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
fix-rate-intermediate-states
branch
from
2c8a127 to
ce36555
Compare
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Sep 15, 2025
| while (j < count) { | ||
| mergedTimestamps[k] = ts.getLong(tsFirst + j); | ||
| mergedValues[k++] = vs.getLong(vsFirst + j++); | ||
| assert count % 2 == 0 : "expected even number of values for intervals, got " + count + " in " + ts; |
There was a problem hiding this comment.
Sorry I missed this, why is this the case?
There was a problem hiding this comment.
We serialize two values for each interval and here assert that the intervals have been serialized correctly.
kkrik-es
reviewed
Sep 15, 2025
| } else { | ||
| timestamps.appendLong(state.timestamps[0]); | ||
| values.appendLong(state.values[0]); | ||
| // don't combine intervals until final as we might have overlapping intervals from other indices |
There was a problem hiding this comment.
I'm wondering, does this mean that we need to send all the data to the coordinating node? Or, we still reduce in the data nodes, before collecting the per-shard data in the coordinating node?
There was a problem hiding this comment.
I updated the comments. We still reduce data points in each shard to a single interval (t1, v1, t2, v2), but we no longer combine intervals across shards until the final phase
kkrik-es
approved these changes
Sep 15, 2025
|
Thanks Kostas! |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Sep 17, 2025
This change reworks the computation of resets to remove the need for using delta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reworks the computation of resets to remove the need for using delta.