ESQL: Always estimate size for types #134701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the "unknown" size estimates for ESQL types - we were defaulting to 50 bytes each and that's just... always more wrong and making a bad estimate for each type.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
I'm marking this as |
carlosdelest
approved these changes
Sep 15, 2025
| OBJECT(builder().esType("object").unknownSize()), | ||
| SOURCE(builder().esType(SourceFieldMapper.NAME).unknownSize()), | ||
| OBJECT(builder().esType("object").estimatedSize(1024)), | ||
| SOURCE(builder().esType(SourceFieldMapper.NAME).estimatedSize(1024)), |
There was a problem hiding this comment.
I wonder if it is worth having even higher estimate for source?
I imagine logs source documents could easily reach 10k
There was a problem hiding this comment.
Yeah. Probably is. Let me give it 10k or so.
There was a problem hiding this comment.
Usually _source is loaded very temporarily - just row by row - in the reader for things like text fields. This just about the METADATA _source thing.
…ways_estimate_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the "unknown" size estimates for ESQL types - we were defaulting to 50 bytes each and that's just... always more wrong and making a bad estimate for each type.