Improve block loader for source only runtime IP fields #135393
Merged
+219
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubik42
added
>enhancement
Team:StorageEngine
:StorageEngine/Mapping
|
Hi @Kubik42, I've created a changelog YAML for you. |
Kubik42
force-pushed
the
kubik-ip-script-block-loader-improvements
branch
from
1d779cd to
b577497
Compare
9 tasks
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @Kubik42, I've created a changelog YAML for you. |
Kubik42
commented
Sep 25, 2025
| import java.net.InetAddress; | ||
| import java.util.List; | ||
|
|
||
| public class IpFallbackSyntheticSourceReader extends FallbackSyntheticSourceBlockLoader.SingleValueReader<InetAddress> { |
There was a problem hiding this comment.
the code between IpScriptFieldType and IpFieldMapper is identical, so I extracted it into a standalone class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #134121