-
Notifications
You must be signed in to change notification settings - Fork 861
Docusaurus theme updates for release #8814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docusaurus theme updates for release #8814
Conversation
3e5d133 to
fe1f7ec
Compare
6eb6ff5 to
8c28777
Compare
fed59ab to
ff9ed67
Compare
💭 Providing steps would make QA more clear and streamlined here. What's required to configure the theme setup? What other dependencies would need to be installed? etc. |
packages/docusaurus-theme/src/theme/Navbar/MobileSidebar/Header/index.tsx
Show resolved
Hide resolved
The reason why I didn't provide them is because we've discussed this topic with @tkajtoch and I was expecting a review from him. So I made a mental shortcut in the QA section because he'd know exactly how to test this. Now that you want to test it, which I'm grateful for, I can spend some time on writing a more detailed description. That being said, I'll ask you for your patience because this PR is of lesser priority like we discussed, and I have some other high priorities I need to handle at the moment. I will just ping you whenever you can review the PR again 😄 Thanks! |
|
@weronikaolejniczak The additional added changes make sense and look good to me. Thanks for adding them! |
packages/docusaurus-theme/src/components/theme_context/index.tsx
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme/src/components/theme_context/index.tsx
Outdated
Show resolved
Hide resolved
|
@mgadewoll the PR is ready to be re-reviewed. Everything should be working as expected in our documentation website. |
packages/docusaurus-theme/src/components/theme_context/index.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 All changes are LGTM and the documentation page works as expected.
Thanks for your diligent work and patience on this! 🎉


Summary
On this PR, I prepare
docusaurus-themeto be released and consumed by other teams at Elastic.Changes
@elastic/euiimports from severity patternpackage.jsonto be ready for package releaseI recommend going commit by commit.
Tip
You can read more about Swizzling component here.
Why are we making this change?
https://github.com/elastic/eui-private/issues/150 - we want to publish
packages/docusaurus-themeso it can be consumed by other teams at Elastic, e.g. Kibana.Screenshots
Incorrect links
Incorrect imports
Much better...
Impact to users
🟢 This is not a breaking change. The documentation website behavior should remain the same.
QA
gh pr checkout 8814yarnyarn workspace @elastic/eui-website build:workspacesyarn workspace @elastic/eui-website startChecklist:
Optionally:
packages/docusaurus-themeand use in a Docusaurus scaffolding (Refer to README.md for instructions)