[Controls] Fix initialization race condition #237726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
ThomThomson
added
Team:Presentation
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nreese
reviewed
Oct 9, 2025
| }); | ||
| }); | ||
|
|
||
| test('should not render DashboardGrid until controls are ready', async () => { |
There was a problem hiding this comment.
Why is this test being removed? I don't think it should be removed
There was a problem hiding this comment.
Whoops, that was a holdover from when I was using pauseFetch to fix the bug in the same PR. Restored this test.
…izationRaceCondition' into controls/fixInitializationRaceCondition
…izationRaceCondition
nreese
reviewed
Oct 9, 2025
There was a problem hiding this comment.
Does filtersReadySubscription need to be clean up? The reason for the debounce is to give time for the filters to propagate to the control group. I don't think this is needed any more.
|
I removed the unnecessary debounce from filtersReadySubscription, but as a follow-up I'd like to look into removing it entirely and making the I decided not to do that in this PR because I'd like to keep this as stable as possible and that would introduce a lot of changes. Additionally, we'll be merging |
nreese
approved these changes
Oct 10, 2025
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.19, 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2025
Fixes a race condition in the controls initialization step. (cherry picked from commit e26e842)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Oct 14, 2025
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Oct 14, 2025
Fixes a race condition in the controls initialization step. (cherry picked from commit e26e842) # Conflicts: # src/platform/plugins/shared/controls/public/control_group/selections_manager.ts # src/platform/plugins/shared/controls/public/controls/data_controls/initialize_data_control.ts # src/platform/plugins/shared/controls/public/controls/data_controls/options_list_control/get_options_list_control_factory.test.tsx # src/platform/plugins/shared/dashboard/public/dashboard_api/control_group_manager.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Oct 14, 2025
Fixes a race condition in the controls initialization step. (cherry picked from commit e26e842) # Conflicts: # src/platform/plugins/shared/controls/public/control_group/selections_manager.ts # src/platform/plugins/shared/controls/public/controls/data_controls/data_control_manager.ts # src/platform/plugins/shared/controls/public/controls/data_controls/options_list_control/get_options_list_control_factory.test.tsx
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Oct 14, 2025
Fixes a race condition in the controls initialization step. (cherry picked from commit e26e842) # Conflicts: # src/platform/plugins/shared/controls/public/control_group/selections_manager.ts # src/platform/plugins/shared/controls/public/controls/data_controls/data_control_manager.ts # src/platform/plugins/shared/controls/public/controls/data_controls/options_list_control/get_options_list_control_factory.test.tsx
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2025
# Backport This will backport the following commits from `main` to `9.2`: - [[Controls] Fix initialization race condition (#237726)](#237726) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Devon Thomson","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-10-14T19:46:49Z","message":"[Controls] Fix initialization race condition (#237726)\n\nFixes a race condition in the controls initialization step.","sha":"e26e842a094f95c0396bdd91f70ecd409956082d","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","release_note:skip","impact:medium","backport:version","v9.2.0","v9.3.0","v8.19.6"],"title":"[Controls] Fix initialization race condition","number":237726,"url":"https://github.com/elastic/kibana/pull/237726","mergeCommit":{"message":"[Controls] Fix initialization race condition (#237726)\n\nFixes a race condition in the controls initialization step.","sha":"e26e842a094f95c0396bdd91f70ecd409956082d"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237726","number":237726,"mergeCommit":{"message":"[Controls] Fix initialization race condition (#237726)\n\nFixes a race condition in the controls initialization step.","sha":"e26e842a094f95c0396bdd91f70ecd409956082d"}},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Devon Thomson <[email protected]>
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Oct 15, 2025
Fixes a race condition in the controls initialization step.
ThomThomson
added a commit
that referenced
this pull request
Oct 15, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[Controls] Fix initialization race condition (#237726)](#237726) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Devon Thomson","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-10-14T19:46:49Z","message":"[Controls] Fix initialization race condition (#237726)\n\nFixes a race condition in the controls initialization step.","sha":"e26e842a094f95c0396bdd91f70ecd409956082d","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","release_note:skip","impact:medium","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6","v9.0.9"],"title":"[Controls] Fix initialization race condition","number":237726,"url":"https://github.com/elastic/kibana/pull/237726","mergeCommit":{"message":"[Controls] Fix initialization race condition (#237726)\n\nFixes a race condition in the controls initialization step.","sha":"e26e842a094f95c0396bdd91f70ecd409956082d"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/239007","number":239007,"state":"OPEN"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237726","number":237726,"mergeCommit":{"message":"[Controls] Fix initialization race condition (#237726)\n\nFixes a race condition in the controls initialization step.","sha":"e26e842a094f95c0396bdd91f70ecd409956082d"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
ThomThomson
added a commit
that referenced
this pull request
Oct 15, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Controls] Fix initialization race condition (#237726)](#237726) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Devon Thomson","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-10-14T19:46:49Z","message":"[Controls] Fix initialization race condition (#237726)\n\nFixes a race condition in the controls initialization step.","sha":"e26e842a094f95c0396bdd91f70ecd409956082d","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","release_note:skip","impact:medium","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6","v9.0.9"],"title":"[Controls] Fix initialization race condition","number":237726,"url":"https://github.com/elastic/kibana/pull/237726","mergeCommit":{"message":"[Controls] Fix initialization race condition (#237726)\n\nFixes a race condition in the controls initialization step.","sha":"e26e842a094f95c0396bdd91f70ecd409956082d"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/239007","number":239007,"state":"OPEN"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237726","number":237726,"mergeCommit":{"message":"[Controls] Fix initialization race condition (#237726)\n\nFixes a race condition in the controls initialization step.","sha":"e26e842a094f95c0396bdd91f70ecd409956082d"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
mgadewoll
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Oct 17, 2025
Fixes a race condition in the controls initialization step.
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
Fixes a race condition in the controls initialization step.
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
Fixes a race condition in the controls initialization step.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
Fixes a race condition in the controls initialization step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition in the controls initialization step. Followup to #237169.
This should make the fix for the double-refetch bug more robust as now the Dashboard panels will not load at all until the Controls have finished initializing, and the control group has finished combining their initial filters into its filters array.
There should be no user-facing changes in this PR as the previous fix worked correctly despite not fixing the underlying race condition as the panel initialization step always takes longer than the filter publish & data view fetch step.
Changes: