Skip to content

[GenAi] Enable the Default LLM Setting feature flag by default <9.1 #238986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

[GenAi] Enable the Default LLM Setting feature flag by default <9.1 #238986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80a1e17
enable the default LLM feature flag by default
KDKHD Oct 14, 2025
51e3f59
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .../packages/shared/ai-assistant-default-llm-setting/src/components/default_ai_connector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,13 @@ import { i18n } from '@kbn/i18n';
import { NO_DEFAULT_CONNECTOR } from '../lib/constants';
import { useDefaultAiConnectorSettingContext } from '../context/default_ai_connector_context';

/** Feature flag for the default AI connector setting */
export const AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED =
'aiAssistant.defaultLlmSettingEnabled' as const;

/** The default value for the default AI connector setting */
export const AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE = true as const;

interface ConnectorData {
connectors?: Array<{
id: string;
Expand Down Expand Up @@ -272,7 +276,12 @@ export const DefaultAIConnector: React.FC<Props> = ({ connectors, settings }) =>
);
}, [elasticManagedLlmExists, application, docLinks]);

if (!featureFlags.getBooleanValue(AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED, false)) {
if (
!featureFlags.getBooleanValue(
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE
)
) {
return null;
}

Expand Down
3 changes: 3 additions & 0 deletions x-pack/solutions/security/plugins/security_solution/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,9 @@ export const DEFAULT_AI_CONNECTOR = 'securitySolution:defaultAIConnector' as con
export const AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED =
'aiAssistant.defaultLlmSettingEnabled' as const;

/** The default value for the default AI connector setting */
export const AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE = true as const;

/** This Kibana Advanced Setting allows users to enable/disable querying cold and frozen data tiers in analyzer */
export const EXCLUDE_COLD_AND_FROZEN_TIERS_IN_ANALYZER =
'securitySolution:excludeColdAndFrozenTiersInAnalyzer' as const;
Expand Down
3 changes: 2 additions & 1 deletion ...ecurity/plugins/security_solution/public/common/hooks/use_default_ai_connector_id.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { getDefaultConnector } from '@kbn/elastic-assistant/impl/assistant/helpe
import {
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
DEFAULT_AI_CONNECTOR,
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE,
} from '../../../common/constants';

jest.mock('../lib/kibana');
Expand Down Expand Up @@ -96,7 +97,7 @@ describe('useDefaultAIConnectorId', () => {

expect(mockFeatureFlags.getBooleanValue).toHaveBeenCalledWith(
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
false
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE
);
});

Expand Down
3 changes: 2 additions & 1 deletion ...ons/security/plugins/security_solution/public/common/hooks/use_default_ai_connector_id.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { getDefaultConnector } from '@kbn/elastic-assistant/impl/assistant/helpe
import { useMemo } from 'react';
import {
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE,
DEFAULT_AI_CONNECTOR,
} from '../../../common/constants';
import { useAIConnectors } from './use_ai_connectors';
Expand All @@ -21,7 +22,7 @@ export const useDefaultAIConnectorId = () => {
const legacyDefaultConnectorId = uiSettings.get<string>(DEFAULT_AI_CONNECTOR);
const useNewDefaultConnector = featureFlags.getBooleanValue(
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
false
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE
);
const newDefaultConnectorId = getDefaultConnector(connectors, settings)?.id;

Expand Down
7 changes: 5 additions & 2 deletions ...ugins/security_solution/public/flyout/ai_for_soc/components/connector_missing_callout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ import { EuiCallOut, EuiLink } from '@elastic/eui';
import { useNavigateTo } from '@kbn/security-solution-navigation';
import { i18n } from '@kbn/i18n';
import { useKibana } from '../../../common/lib/kibana';
import { AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED } from '../../../../common/constants';
import {
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE,
} from '../../../../common/constants';

const MISSING_CONNECTOR = i18n.translate('xpack.securitySolution.alertSummary.missingConnector', {
defaultMessage: 'Missing connector',
Expand Down Expand Up @@ -56,7 +59,7 @@ export const ConnectorMissingCallout = memo(
const { featureFlags } = useKibana().services;
const useNewDefaultConnector = featureFlags.getBooleanValue(
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
false
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE
);
const { navigateTo } = useNavigateTo();
const goToKibanaSettings = useCallback(
Expand Down