-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Execution context] Add space id #245704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jesuswr
wants to merge
7
commits into
elastic:main
Choose a base branch
from
jesuswr:add-space-id-to-execution-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Execution context] Add space id #245704
+308
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ci |
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
Author
|
/ci |
2 similar comments
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Page load bundle
History
cc @jesuswr |
591e8de to
dedbb9e
Compare
Contributor
Author
|
/ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This PR does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #237140
Adds space ID to the execution context for both browser and server environments to improve observability and traceability of operations across different Kibana spaces.
Browser Implementation
Server Implementation
append()method toExecutionContextSetupAPI that allows safely appending the space ID to the current execution context without replacing the entire objectappend()method in the request interceptor that already has the space.The only thing to consider is that this doesn't work for the task manager tasks since they use
withContextdirectly, so there's no way for us to set the space for them.kibana/x-pack/platform/plugins/shared/task_manager/server/task_running/task_runner.ts
Lines 412 to 421 in 4542335
This is how it looks like in the server:

Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.