🌊 Add task service and client to manage background tasks #245725
Draft
+280
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
author:actionable-obs
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
klacabane
reviewed
Dec 10, 2025
Comment on lines
+31
to
+33
| const response = await this.storageClient.get({ | ||
| id, | ||
| }); |
Contributor
There was a problem hiding this comment.
Do we need to store the task state on our end or can we use the task manager interface ? Can the task manager tell us the state of a task given an id ?
Contributor
Author
There was a problem hiding this comment.
Single run tasks are deleted upon completion, so neither status nor state is stored.
klacabane
reviewed
Dec 10, 2025
| id: types.keyword(), | ||
| status: types.keyword(), | ||
| payload: types.object({ enabled: false }), | ||
| error: types.keyword(), |
Contributor
There was a problem hiding this comment.
We need a created_at field and some timeout logic in the scheduling route to prevent a failed task from being in running mode indefinitely
klacabane
reviewed
Dec 10, 2025
| request: KibanaRequest; | ||
| } | ||
|
|
||
| export class TaskClient<TaskType extends string> { |
Contributor
There was a problem hiding this comment.
should probably use a lockManager unless the taskManager provides a guard for us ? what happens if we schedule a task with the same id ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See WIP usage here