refactor: simplify nuspec file structure by consolidating file entries into a single pattern

[beyondkmp]

fix #9092

The app output of electron-builder is placed in a temporary directory, so we can directly copy all files into lib\net45 without needing to perform filtering.

[changeset-bot]

⚠️ No Changeset found

Latest commit: cba48ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[mmaietta]

I don't think this is a necessary change. I'd prefer explicit file includes as opposed to a glob + exclude filter. Is there a performance benefit to this PR?

[beyondkmp]

The old version used to copy all files into \lib\net45, so this approach doesn't seem to be an issue.

[mmaietta]

The old version used to copy all files into \lib\net45, so this approach doesn't seem to be an issue.

I don't see a reason for this change from the current functionality being provided - this simplification doesn't seem needed. Allowlists are always my more preferred approach when it comes to production assets, not blocklists using exclude="**\.git and other exclusions as we can't guarantee if other files might accidentally be included by the end-developer's app configuration/setup.

If we're needing to handle extraFiles in being included, then can we explicitly pipe those into the inclusion array?

[beyondkmp]

@mmaietta How about we make this template file customizable? If users need to include more files, they could specify their own template. If none is specified, the current default template would be used.

[mmaietta]

Hmmm, that's a great proposal to handle very advanced use cases, not sure if the average dev will understand how to go that deep into nuspec.

Is there a way we could just loop through a property on squirrel for customizing the accepted/to-be-copied files?
Similar how it already does for:

    <file src="<%- exe %>" target="lib\net45\<%- exe %>" />
    <% additionalFiles.forEach(function(f) { %>
    <file src="<%- f.src %>" target="<%- f.target %>" />
    <% }); %>

[github-actions]

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment, or this will be closed in 30 days.

[mmaietta]

@beyondkmp friendly ping on #9140 (comment)

Let me know what the best next steps are, but currently, I'm not a fan of having a globstar "all" regex

[beyondkmp]

No better solution has been identified yet. The previous approach used by the old Squirrel.Windows version was to package all contents from the app directory into lib\net45 without any filtering. Therefore, the current idea is to simply include the entire app directory without any filtering.

[mmaietta]

I like this approach!

Can you create a const for this? (similar to searchString on line 170)

const additionalFilesReplaceKey = '<% file src="additionalFiles.src" target="additionalFiles.target" / %>'

[mmaietta]

Is this expected behavior? If we're testing just extraFiles, then I'd rather it not be the index.html since it may get misconstrued as part of the normal bundle when comparing manually comparing snapshot diffs.

Maybe create a temp file in the unit test?

[github-actions]

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment, or this will be closed in 30 days.