Skip to content

Conversation

@drivron
Copy link
Contributor

@drivron drivron commented Oct 2, 2025

There is an issue with the PR #9151 on the call to doGetBin in binDownload.ts. This function is now called with cacheName, which produces an invalid value when ELECTRON_BUILDER_CACHE is set.
For example, if ELECTRON_BUILDER_CACHE="~cache", the following command is called and fails: app-builder.exe download-artifact --name ~cachewinCodeSign; and the following directory is created: ~cache/~cachewinCodeSign/590582919.

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025

🦋 Changeset detected

Latest commit: e7eefee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta mmaietta changed the title Fixed the call to “download-artifact” when ELECTRON_BUILDER_CACHE is … fix: incorrect cache name set when ELECTRON_BUILDER_CACHE env var is present Oct 2, 2025
@Julusian
Copy link
Contributor

Julusian commented Oct 5, 2025

I have just discovered this exact issue and came up with the same fix.
It was resulting in paths too long for windows to handle:

Error: C:\actions-runner-bitfocus\_work\companion-satellite\companion-satellite\.cache\electron-builder\Cactions\Cactions-runner-bitfocus_workcompanion-satellitecompanion-satellite.cacheelectron-buildernsis-3.0.4.1-nsis-3.0.4.1\Bin\makensis.exe process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE

@mmaietta mmaietta merged commit e5f5799 into electron-userland:master Oct 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants