fix: incorrect cache name set when ELECTRON_BUILDER_CACHE env var is present #9293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the PR #9151 on the call to
doGetBininbinDownload.ts. This function is now called withcacheName, which produces an invalid value whenELECTRON_BUILDER_CACHEis set.For example, if
ELECTRON_BUILDER_CACHE="~cache", the following command is called and fails:app-builder.exe download-artifact --name ~cachewinCodeSign; and the following directory is created:~cache/~cachewinCodeSign/590582919.