Fix duration of voice message in timeline #30973
Merged
+50
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 68bcfbe.
Half-Shot
reviewed
Oct 8, 2025
florianduros
changed the title
florianduros
force-pushed
the
florianduros/fix-audio-playback
branch
from
9478ddd to
bb027d9
Compare
Half-Shot
approved these changes
Oct 8, 2025
dbkr
reviewed
Oct 9, 2025
| // incomplete or stopped, thus giving an accurate position within the active | ||
| // clip segment. | ||
| return (this.context.currentTime - this.clipStart) % this.clipDuration; | ||
| return (this.context.currentTime - this.clipStart) % this.clipDuration || 0; |
There was a problem hiding this comment.
Result of a modulo operation must always be an integer I think, so the only value where it could be falsy is 0 anyway?
There was a problem hiding this comment.
I had a NaN at some point, one of the values wasn't an integer
dbkr
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30958
Revert part of #30961 to fix the root problem