Fix: member count in header and member list #30982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
changed the title
florianduros
force-pushed
the
florianduros/members
branch
2 times, most recently
from
4e79957 to
83ba237
Compare
florianduros
force-pushed
the
florianduros/members
branch
from
83ba237 to
38d65ac
Compare
florianduros
force-pushed
the
florianduros/members
branch
from
64433b5 to
18907da
Compare
t3chguy
reviewed
Oct 9, 2025
|
|
||
| setMemberMap(newMemberMap); | ||
| setMemberCount(joinedSdk.length + invitedSdk.length + threePidInvited.length); | ||
| setMemberCount(room.getInvitedAndJoinedMemberCount() + threePidInvited.length); |
There was a problem hiding this comment.
If using the summary counts you need to watch for RoomEvent.Summary to update them when they change
t3chguy
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30940
The room header is still missing the 3Pid invits but I guess it's better