Explain the purpose of signing keys in the config documentation. #5286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
f662b0b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://caf306f4.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-doc-keys.matrix-authentication-service-docs.pages.dev |
reivilibre
force-pushed
the
rei/doc_keys
branch
from
ded1eac to
f662b0b
Compare
reivilibre
changed the title
reivilibre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some questions about what these were used for; I gave answers along these lines. I have now reworded a little for the docs.
@sandhose Please check you agree with them :D
A relevant issue that I haven't addressed is #4806, which asks about the significance of the order of
keys.I didn't want to commit to any specific behaviour except the ranking based on claim matching, because the fact we do a stable sort and pick the last key in the list seems like an implementation detail and anything relying on it seems brittle.