Add 'IF NOT EXISTS' to all 'CREATE INDEX CONCURRENTLY' statements to avoid deadlocks #5297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESS CI is sometimes seeing issues where MAS (with multiple replicas) refuses to initially startup
The Postgres logs show
DB migration jobs then fail with
relation "compat_access_tokens_session_fk" already exists.On discussion this is the first migration that isn't in a transaction / uses
CREATE INDEX CONCURRENTLY. It is assumed that removingCONCURRENTLYisn't desirable as will cause slowness on large MAS DBs upgrading, so useIF NOT EXISTSto subsequent migration attempts to progress. Unclear whether this will stop the deadlock in the first place but this shouldn't make the problem any worse