Don't persist known bad room state from /state_ids #18877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are told the state before event E is S via
/state_ids
, we should refuse to persist E if we fail to persist all events in S, else we are knowingly diverging from that server.This causes room state to diverge on bad federation connectivity.
Discovered via Chaos testing.
Pending Complement tests.
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.