Skip to content

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Sep 30, 2025

MSC2732 (Olm fallback keys) was accepted in 2022. We shouldn't need to continue supporting the unstable field names.

Split out from #17097.


Note: this PR was accidentally committed to develop early (2aab171), hence the minimal diff in the PR, which now only introduces changelog entry for the changes.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@anoadragon453 anoadragon453 marked this pull request as ready for review September 30, 2025 16:14
@anoadragon453 anoadragon453 requested a review from a team as a code owner September 30, 2025 16:14
@MadLittleMods MadLittleMods changed the title Remove unstable prefixes for MSC2732 Remove unstable prefixes for MSC2732: Olm fallback keys Oct 2, 2025
@@ -0,0 +1 @@
Drop support for unstable field names from the long-accepted MSC2732 proposal. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you might have pushed this to develop already -> 2aab171

And I guess this branch is just out of date

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! That would explain why the unit tests on #17097 were passing... Likely happened when performing a release after adding this commit to my local develop checkout.

@anoadragon453 anoadragon453 merged commit 5465c68 into develop Oct 7, 2025
35 checks passed
@anoadragon453 anoadragon453 deleted the anoa/drop_msc2732_unstable_field_names branch October 7, 2025 10:15
anoadragon453 added a commit that referenced this pull request Oct 7, 2025
anoadragon453 added a commit that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants