Inspect ill-formed structs as maps #14718
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabiwara
commented
Aug 20, 2025
Comment on lines
-203
to
-209
| test "inspect" do | ||
| asc = %{__struct__: Range, first: 1, last: 3} | ||
| desc = %{__struct__: Range, first: 3, last: 1} | ||
|
|
||
| assert inspect(asc) == "1..3" | ||
| assert inspect(desc) == "3..1//-1" | ||
| end |
There was a problem hiding this comment.
These will be rendered as maps, which I think is acceptable now?
It's been a while since stepped ranges.
sabiwara
commented
Aug 20, 2025
lib/elixir/lib/inspect.ex
Outdated
| for %{field: field} = map <- info, | ||
| field != :__exception__, | ||
| do: map | ||
| if info = Inspect.Map.valid_struct_info(struct) do |
There was a problem hiding this comment.
Actually do we still need this if it is handled upstream in Inspect.Algebra?
Perhaps I could just call module.__info__(:struct) directly, I wasn't sure.
There was a problem hiding this comment.
I went with cab02a1, let me know if that's OK.
josevalim
reviewed
Aug 20, 2025
lib/elixir/lib/inspect/algebra.ex
Outdated
| @@ -396,7 +396,7 @@ defmodule Inspect.Algebra do | |||
| def to_doc_with_opts(term, opts) | |||
|
|
|||
| def to_doc_with_opts(%_{} = struct, %Inspect.Opts{inspect_fun: fun} = opts) do | |||
| if opts.structs do | |||
| if opts.structs and Inspect.Map.valid_struct?(struct) do | |||
There was a problem hiding this comment.
Should we move the function to this module instead?
There was a problem hiding this comment.
Indeed makes sense, I initially thought I'd need it at several places but not anymore 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #14717